Use ruby/setup-ruby Action for CI Workflow #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alhadis
approved these changes
Dec 2, 2020
Done. Merging. Thanks for the quick review @Alhadis 馃檱 |
|
I'd literally just finished scanning the CI logs to figure out what went wrong. 馃槀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We seem to have started to hit a problem with the 2.5 builds thanks to
actions/setup-rubyapparently no longer including bundler by default, so CI fails with:This PR addresses that by switching us to the more actively maintained ruby/setup-ruby action which takes care of installing bundler, gems and caching for us.
I've also taken the chance to simplify things and move the checking out of the all the grammar submodules to the workflow itself and removed the old script.
This new setup with
ruby/setup-rubyalso appears to cut about 2 minutes off the entire CI run too 馃帀I'll update the required checks when this is ready to be merged.