Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color for Groovy to match the logo on the website #5418

Merged
merged 3 commits into from Jul 23, 2021

Conversation

yogurtearl
Copy link
Contributor

@yogurtearl yogurtearl commented Jun 11, 2021

Change color for Groovy Language

Current: #e69f56
Proposed: #4298b8

From the Groovy logo on the groovy website:
https://github.com/apache/groovy-website/blob/f51c26b05f90edc05873a2a1ec676a8f58fe4f7c/site/src/site/assets/css/style.css#L487

Current Color:
image

Proposed Color in taken from the website:
image

@yogurtearl yogurtearl requested a review from a team as a code owner June 11, 2021 05:12
@yogurtearl yogurtearl changed the title Change color for Groovy Language Update color for Groovy to match the logo on the website Jun 11, 2021
@jnorthr
Copy link

jnorthr commented Jun 16, 2021

cool idea - just do it !

@lildude
Copy link
Member

lildude commented Jun 24, 2021

If #5384 gets enough community support it'll bring Java and Groovy closer to each other again 😁

@GavinRay97
Copy link

If #5384 gets enough community support it'll bring Java and Groovy closer to each other again 😁

If not coordinated -- that is absolutely hilarious.
Please pick one or the other I guess haha.

@Nixinova Nixinova mentioned this pull request Jul 20, 2021
2 tasks
@lildude
Copy link
Member

lildude commented Jul 21, 2021

I'm going to accept this colour change and lock comments on this issue once merged. If there are any disagreements or opinions about the colour change, they need to be discussed in the community discussion linked in the OP and not in this repo as this is a community requested and supported change, not a GitHub/Linguist initiated change.

Note, I'll accept the Java colour change in #5384 too under the same circumstances once it gets a community-based discussion link (/cc @ZacSweers as the author of that PR). When that happens both languages will still have similar looking colours:

Old

  • Groovy: #e69f56
  • Java: #b07219

New

  • Groovy: #4298b8
  • Java: #2a6277

@GavinRay97
Copy link

GavinRay97 commented Jul 21, 2021

Ruh-roh

image

@lildude lildude merged commit c492ac0 into github-linguist:master Jul 23, 2021
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants