Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JAR Manifest file #5505

Merged
merged 6 commits into from
Aug 26, 2021
Merged

Add JAR Manifest file #5505

merged 6 commits into from
Aug 26, 2021

Conversation

Nixinova
Copy link
Contributor

@Nixinova Nixinova commented Aug 6, 2021

Description

Adds support for JAR MANIFEST.MF files.

Checklist

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
    • I have included a syntax highlighting grammar:
      • Uses YAML's one. Lightshow doesn't like it but Manifest is valid YAML syntax so there shouldnt be an issue. Gist works though.
    • I have updated the heuristics to distinguish my language from others using the same extension.

@Nixinova Nixinova requested a review from a team as a code owner August 6, 2021 20:38
@Nixinova
Copy link
Contributor Author

Nixinova commented Aug 6, 2021

Why the case sensitivity?

  1) Failure:
TestSamples#test_filename_listed [/home/runner/work/linguist/linguist/test/test_samples.rb:49]:
/home/runner/work/linguist/linguist/samples/Manifest/filenames/MANIFEST.MF isn't listed as a filename for Manifest in languages.yml.
Expected ["manifest.mf"] to include "MANIFEST.MF".

  2) Failure:
TestFileBlob#test_language [/home/runner/work/linguist/linguist/test/test_file_blob.rb:652]:
No language for /home/runner/work/linguist/linguist/samples/Manifest/filenames/MANIFEST.MF

lib/linguist/languages.yml Outdated Show resolved Hide resolved
@lildude lildude merged commit 9ce3a87 into github-linguist:master Aug 26, 2021
@Nixinova Nixinova deleted the manifest branch August 27, 2021 00:18
kalkin added a commit to kalkin/file-expert that referenced this pull request Sep 19, 2021
Alhadis added a commit to file-icons/atom that referenced this pull request Dec 28, 2021
Added:
* Config, Python: `.flake8`       (github-linguist/linguist#5669)
* C++:            `.ixx`          (github-linguist/linguist#5680)
* Database:       `MANIFEST.MF`   (github-linguist/linguist#5505)
* Docker:         `Containerfile` (github-linguist/linguist#5588)
* GLSL:           `.r{chit,miss}` (github-linguist/linguist#5566)
* HTML:           `.hta`          (github-linguist/linguist#5533)
* Makefile:       `.makefile`     (github-linguist/linguist#5526)
* Readme:         `CITATION.cff`  (github-linguist/linguist#5577)
* Shell:          `.kshrc`        (github-linguist/linguist#5685)
* TypeScript:     `.cts`, `.mts`  (github-linguist/linguist#5696)
* XML:            `.hzp`          (github-linguist/linguist#5626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for MANIFEST.MF
3 participants