Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight .gitattributes file should be committed #5670

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Highlight .gitattributes file should be committed #5670

merged 3 commits into from
Feb 8, 2022

Conversation

ekroon
Copy link
Contributor

@ekroon ekroon commented Dec 2, 2021

I added clarification in the documentation about the need to commit .gitattributes file while using Linguist locally.

Screenshot 2021-12-02 at 08 12 33

@ekroon ekroon requested a review from a team as a code owner December 2, 2021 07:14
@lildude lildude requested a review from Alhadis December 8, 2021 11:28
Alhadis
Alhadis requested changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document is full of important points. What makes this one deserving of a callout?

docs/overrides.md Outdated Show resolved Hide resolved
@ekroon
Copy link
Contributor Author

ekroon commented Dec 14, 2021 •
edited

I found it very unintuitive that my changes to .gitattributes weren't picked up. And then this line is very important to pick out of the documentation.

ekroon and others added 2 commits December 14, 2021 22:53
@ekroon @Alhadis
Update docs/overrides.md
3a84dc6 
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
@ekroon
Merge branch 'master' into patch-1
3c4feda
@lildude lildude merged commit 069d07d into github-linguist:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alhadis Alhadis Alhadis requested changes

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekroon @lildude @Alhadis