-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PHP highlighting #5677
Update PHP highlighting #5677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you didn't use the add-grammar
script as per the docs to switch out the grammars, or if you did you've forgotten to commit & push the updates to the grammars README and cached license files.
Please use that script to replace to grammars and or push the missing changed files.
Additionally, have you checked all the grammar changes correctly render on Lightshow? I ask because TextMate uses Oniguruma but GitHub uses PCRE and some of the Oniguruma syntax isn't 100% compatible.
Sorry, I haven't noticed that, I just thought that updating the submodule is sufficient. I don't have much luck with the This is the output I'm getting:
Why I try to run
With Output
And I don't know how to move forward with that :/ |
33c8662
to
328097c
Compare
Ah, looks like you're hitting one of the many problems with the macOS-supplied version of Ruby, which is why we discourage its use in the first part of the CONTRIBUTING.md file. You'll find all your problems disappear if you use a Ruby installed via one of the other means. |
Alright, I installed
Let's see if it finishes. |
Alright, I got at the end but I realized I have to initialize and update all the submodules, otherwise the |
328097c
to
d6c3a04
Compare
Should be fine now, thank you. |
d6c3a04
to
2a9b836
Compare
Build failed, so I updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking on maintaining this grammar.
Awesome, thank you! 👏 |
Description
Based on #5668 I updated the repo that's used for PHP highlighting.
These are the features I added:
I tested these changes in the TextMate editor on macOS.
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality
I am changing the color associated with a language