Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Vala's language color to match the actual logo of Vala #5711

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

Marki2019
Copy link
Contributor

@Marki2019 Marki2019 commented Dec 26, 2021

This Pull Request changes the colour that indicates Vala code across GitHub to match the Vala logo’s background colour: #A56DE2.

https://raw.githubusercontent.com/elementary/brand/master/vala/vala-social.png

Background of Vala's Logo

Checklist:

  • I am changing the color associated with a language
    • I have obtained agreement from the wider language community on this color change.

@Marki2019 Marki2019 requested a review from a team as a code owner December 26, 2021 16:03
@github-linguist github-linguist deleted a comment Jan 4, 2022
@Marki2019
Copy link
Contributor Author

Um why did github comment on my PR lmfao

@JeysonFlores
Copy link

JeysonFlores commented Jan 29, 2022

Are there any plans to evaluate this PR @Alhadis ?

@Alhadis
Copy link
Collaborator

Alhadis commented Jan 29, 2022

@JeysonFlores I've given this an approving review, but site policy requires a GitHub staff member to give their A-OK before a pull-request can be merged. So you'll need to wait until @lildude has time off to work on Linguist. 😉

@JeysonFlores
Copy link

Oh, I get it. Thanks for taking your time to answer!

@colinkiama
Copy link

Any updates on this?

Saw that a bunch of PRs got merged a few weeks ago.

@JeysonFlores
Copy link

Yeah it would be nice to see what happened to this PR

@lildude
Copy link
Member

lildude commented Mar 24, 2022

Whoops, sorry I missed this before. 38 votes seems to be a really really low indicator of wider community support, but given this is going from a bland nondescript colour to a more representative one, I'll let this pass.

Any objects will need to be raised in the sub-Reddit where this was discussed/voted.

@lildude lildude merged commit 34f5c1e into github-linguist:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants