Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Witcher Script language #5770

Merged
merged 13 commits into from
Feb 10, 2022
Merged

Conversation

abheekda1
Copy link
Contributor

@abheekda1 abheekda1 commented Feb 8, 2022

Added the Witcher Script language, a programming language commonly used in the Witcher 3 and its mods.

Description

For the Witcher mods on GitHub, it's been difficult to navigate them and detect them due to the lack of language detection so I was hoping to combat that with this PR.

Checklist:

@abheekda1 abheekda1 requested a review from a team as a code owner February 8, 2022 22:37
@abheekda1 abheekda1 changed the title Add the WitcherScript language Add the Witcher Script language Feb 8, 2022
.gitmodules Show resolved Hide resolved
lib/linguist/languages.yml Show resolved Hide resolved
@abheekda1
Copy link
Contributor Author

https://github.com/ADawesomeguy/witcherscript-grammar license has been changed to MIT :)

@lildude
Copy link
Member

lildude commented Feb 9, 2022

https://github.com/ADawesomeguy/witcherscript-grammar license has been changed to MIT :)

Great. You need to re-add the grammar to update the cached license file in this PR.

@abheekda1
Copy link
Contributor Author

Updated the submodule, think it should all be good now.

@lildude
Copy link
Member

lildude commented Feb 9, 2022

Updated the submodule, think it should all be good now.

Nope. The cached license file is still empty.

@abheekda1
Copy link
Contributor Author

abheekda1 commented Feb 9, 2022

Was there something I had to do other than update the submodule? This is the commit it should be on: https://github.com/ADawesomeguy/witcherscript-grammar/tree/ad11b5ee5414f27436664ade51c1b6d6a4d44e48 and it seems to include the correct license. Where can I see the cache?

@lildude
Copy link
Member

lildude commented Feb 9, 2022

When you replaced the grammar using script/add-grammar, it should have cached the license file.

You can also run bundle exec licensed cache -c vendor/licenses/config.yml to update just that file (it'll check the others too, but we're only interested in the file for this grammar).

@abheekda1
Copy link
Contributor Author

Alright, should be fixed now; I did a git diff after running your command and it seems to have updated the license as well as the hash itself. Thanks!

@abheekda1
Copy link
Contributor Author

Alright so I think I know why some of the tests failed: 8d82142

@abheekda1
Copy link
Contributor Author

Ok just tested it locally, it should all be working now after the last few commits.

@abheekda1
Copy link
Contributor Author

At least it's a new error. I updated the submodule cached version so it should work now (I think)

@lildude lildude merged commit 7c0b31d into github-linguist:master Feb 10, 2022
@abheekda1 abheekda1 deleted the witcherscript branch February 10, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants