-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .pbt
as an extension for Protocol Buffer Text
#5771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a sample for this extension too and update the OP to state where the file came from and the license that covers it.
I'm unsure about how to best deal with the fact that PowerBuilder also uses pbt |
We normally rely on heuristics if the structures of the languages are quite similar but have unique ways to distinguish them. In this case, I think they're sufficiently different that we can rely on the classifier. To increase the chances of the classifier getting it right, please add another Proto buffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@lildude Sorry for the bump in here but is there a way to know which version of linguist is currently deployed on GitHub? I just want to make sure there was no issue with my PR because I don't see any of the repos using the new attribution yet. |
7.21.0... deployed this morning, however this PR shipped with 7.19.0 which was deployed waaaaay back in February.
You need to push a change for your repo to be re-analysed to pick up any new languages etc. It would also only appear as the language in a list of repos if this were the primary language of the repo. |
Oh yes, I also forgot to say: the language is "data" so won't show in the language stats unless someone explicitly sets the Syntax highlighting is however working and easy to check. |
@lildude oh I see, thank you! I had assumed that it would be detectable by default, so I assume everyone who uses it will have to add the |
Yup, but only if they want it to show in their language stats. |
Description
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality
I am changing the color associated with a language