Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pbt as an extension for Protocol Buffer Text #5771

Merged
merged 5 commits into from
Feb 10, 2022

Conversation

Stanzilla
Copy link
Contributor

@Stanzilla Stanzilla commented Feb 9, 2022

Description

Checklist:

@Stanzilla Stanzilla requested a review from a team as a code owner February 9, 2022 17:53
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a sample for this extension too and update the OP to state where the file came from and the license that covers it.

@Stanzilla
Copy link
Contributor Author

I'm unsure about how to best deal with the fact that PowerBuilder also uses pbt

@lildude
Copy link
Member

lildude commented Feb 9, 2022

I'm unsure about how to best deal with the fact that PowerBuilder also uses pbt

We normally rely on heuristics if the structures of the languages are quite similar but have unique ways to distinguish them. In this case, I think they're sufficiently different that we can rely on the classifier. To increase the chances of the classifier getting it right, please add another Proto buffer .pbt sample. The "Classifier cross-validation" test should highlight if this is sufficient (it needs two samples per language).

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lildude lildude merged commit e6e0a44 into github-linguist:master Feb 10, 2022
@Stanzilla
Copy link
Contributor Author

@lildude Sorry for the bump in here but is there a way to know which version of linguist is currently deployed on GitHub? I just want to make sure there was no issue with my PR because I don't see any of the repos using the new attribution yet.

@Stanzilla Stanzilla deleted the patch-1 branch June 10, 2022 16:03
@lildude
Copy link
Member

lildude commented Jun 10, 2022

there a way to know which version of linguist is currently deployed on GitHub?

7.21.0... deployed this morning, however this PR shipped with 7.19.0 which was deployed waaaaay back in February.

I just want to make sure there was no issue with my PR because I don't see any of the repos using the new attribution yet.

You need to push a change for your repo to be re-analysed to pick up any new languages etc.

It would also only appear as the language in a list of repos if this were the primary language of the repo.

@lildude
Copy link
Member

lildude commented Jun 10, 2022

Oh yes, I also forgot to say: the language is "data" so won't show in the language stats unless someone explicitly sets the linguist-detectable override. This applies to all "data" languages.

Syntax highlighting is however working and easy to check.

@Stanzilla
Copy link
Contributor Author

@lildude oh I see, thank you! I had assumed that it would be detectable by default, so I assume everyone who uses it will have to add the linguist-detectable attribute in their .gitattributes file still?

@lildude
Copy link
Member

lildude commented Jun 10, 2022

Yup, but only if they want it to show in their language stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants