Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 2D Array data type #5785

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Conversation

abheekda1
Copy link
Contributor

@abheekda1 abheekda1 commented Feb 15, 2022

I added the 2da filetype which is used in some of BioWare's game engines and in games such as the first Witcher.

Description

Not really much more to describe. For some reason there where changes made to other areas which was either a Git mistake by me or an automated script thing.

Checklist:

  • I am adding a new language.

@abheekda1 abheekda1 requested a review from a team as a code owner February 15, 2022 04:17
@Nixinova
Copy link
Contributor

Your clone is out of date.
Also the samples/2D Array/appearance.2da file is way too big.

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually BioWare's format, not Bethesda's (unless they've been using the Infinity Engine when I wasn't looking…).

Also, as pointed out by @Nixinova, you'll need to provide (much) smaller samples. Truncating each of the files you've provided to the first 100 lines should be more than enough.

grammars.yml Outdated Show resolved Hide resolved
grammars.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
vendor/README.md Show resolved Hide resolved
@abheekda1
Copy link
Contributor Author

Alright cool, I accidentally mistyped lol.

@abheekda1
Copy link
Contributor Author

I'll fix all the changes you requested and push tomorrow because it's kinda late for me tonight.

- Truncated the samples
- Fixed the name (2D Array to 2-Dimensional Array)
- Remove the extra added exts for other languages
@abheekda1
Copy link
Contributor Author

Alright, I think everything's fixed, please let me know if there's anything else you need me to do.

@abheekda1
Copy link
Contributor Author

@Alhadis I removed the conflicting scope, feel free to modify this PR to include your grammar and rearrange the submodules :)

@Alhadis
Copy link
Collaborator

Alhadis commented Feb 15, 2022

Just did. 😉 Thanks for your patience!

@lildude lildude merged commit cffd401 into github-linguist:master Feb 16, 2022
@abheekda1 abheekda1 deleted the 2d-array branch February 16, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants