Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir and PHP now use Treesitter grammars #5797

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

lildude
Copy link
Member

@lildude lildude commented Feb 21, 2022

Description

GitHub now uses the Treesitter grammars for Elixir and PHP. This PR updates the script/list-grammars script and the resulting README.md to reflect this.

[ Template removed as it doesn't apply ]

@lildude lildude requested a review from a team as a code owner February 21, 2022 09:54
@lildude lildude merged commit c132e25 into master Feb 21, 2022
@lildude lildude deleted the lildude/more-treesitters branch February 21, 2022 09:58
@@ -9,10 +9,12 @@ TREE_SITTER_GRAMMARS = {
"CodeQL" => "https://github.com/tree-sitter/tree-sitter-ql",
"CSS" => "https://github.com/tree-sitter/tree-sitter-css",
"EJS" => "https://github.com/tree-sitter/tree-sitter-embedded-template",
"Elixir" => "https://github.com/elixir-lang/tree-sitter-elixir",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the process GitHub uses for selecting a community repository for Tree-Sitter?

I'd hate to write a grammar only for it to some day be quietly dropped in favour of somebody else's work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure as I'm not part of that team. I'll see if I can find out.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lildude were you able to find out? I'm also very curious about tree-sitter grammars from the community

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. See #6073

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for answering so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants