Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LigoLANG #5811

Merged
merged 18 commits into from
Mar 31, 2022
Merged

Add LigoLANG #5811

merged 18 commits into from
Mar 31, 2022

Conversation

pewulfman
Copy link
Contributor

@pewulfman pewulfman commented Mar 2, 2022

Description

Checklist:

@pewulfman pewulfman requested a review from a team as a code owner March 2, 2022 09:59
@pewulfman
Copy link
Contributor Author

Not sure about the License. I generate it with the script but I pull this from my grammar repo. I think you need the license of the language right?

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to need a sample for each extension you're adding support for.

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These languages are syntactically similar enough to their namesakes that we can afford to reuse their CodeMirror and ACE modes.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
pewulfman and others added 7 commits March 7, 2022 19:48
Co-authored-by: Nixinova <nixinova@gmail.com>
Co-authored-by: Nixinova <nixinova@gmail.com>
Co-authored-by: Nixinova <nixinova@gmail.com>
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
@pewulfman
Copy link
Contributor Author

Thanks for the reviews

We're going to need a sample for each extension you're adding support for.

I have added samples for the other two languages.

These languages are syntactically similar enough to their namesakes that we can afford to reuse their CodeMirror and ACE modes.

thanks, I committed your suggestions :)

lib/linguist/languages.yml Outdated Show resolved Hide resolved
@github-linguist github-linguist deleted a comment from lildude Mar 10, 2022
@lildude lildude changed the title Adding LigoLANG detection and syntax highlighting Add LigoLANG Mar 24, 2022
@lildude
Copy link
Member

lildude commented Mar 24, 2022

Looks like you've got some test failures to address too.

@pewulfman
Copy link
Contributor Author

Looks like you've got some test failures to address to

you are right. It should be fix now

@pewulfman
Copy link
Contributor Author

Ok. We should be ready to merged

@lildude lildude merged commit 323ec12 into github-linguist:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants