New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Git Revision List files #5903
Add support for Git Revision List files #5903
Conversation
Adapted from the generic hash-commented grammar, with highlighting for invalid lines.
🤔 does this really need its own entry? Why not add it to the list of files under the “Ignore List”? From a quick test it highlights fine. |
I defaulted to using a separate language so it could have the invalid content highlighting but I can change it to be under Ignore-List if you would prefer that. |
I hadn't considered invalid syntax, but now you mention it, it looks like the current gitignore grammar doesn't handle invalid syntax either so maybe it's worth updating that instead? |
@lildude The grammar used to highlight For that reason, I'd advise against enforcing any lexical integrity via highlighting, especially since whitespace in a pathname with spaces/ |
@Nixinova I've sent you a pull-request to correct a few remaining highlighting issues, as well as to rename the grammar for the reasons I explained earlier. Your PR will need to be updated to reflect the outcome of that PR. |
Description
Adds the simple git-blame-ignore-revs file format, which is just a list of commit hashes with hash-comments allowed.
Checklist:
Not sure whether the submodule updating was committed.