Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .bb file extension for Babashka to Clojure #5931

Merged
merged 10 commits into from Jun 8, 2022

Conversation

not-in-stock
Copy link
Contributor

@not-in-stock not-in-stock commented Jun 8, 2022

Description

  • Added new extension to Clojure group in lib/linguist/languages.yml
  • Added a sample of Babashka code in samples/Clojure/tell-number.bb
  • Added heuristic to make linguist distinguish between Babashka, BlitzBasic, and BitBake source files.

Checklist:

@not-in-stock not-in-stock requested a review from a team as a code owner June 8, 2022 07:43
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample source(s):

You need to link to the actual source of the real-world sample file you have added, not the file within the Linguist PR 😁. We also need to know the license of the source file. Hint: that's what that section of the template that you deleted was for 😬.

The sample is also quite small which means it's not going to perform very well in circumstances where things slip past the heuristic. Please add at least one more sample, ideally a larger one (but not too large) that is more representative of the language.

@lildude lildude changed the title Amend *.bb file extension for Babashka (Clojure dialect) Add .bb file extension for Babashka to Clojure Jun 8, 2022
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tips to get the tests passing

lib/linguist/languages.yml Outdated Show resolved Hide resolved
samples/Clojure/validate-and-format.bb Show resolved Hide resolved
@not-in-stock not-in-stock requested a review from lildude June 8, 2022 12:28
@lildude lildude merged commit 3ccee19 into github-linguist:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants