Rename Delphi to Pascal #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2013 03:10
|
This needs rolling back. Pure Delphi projects are now detected as "Other". The removal of the samples in lib/linguist/samples.json might be the cause. It might be reasonable to call both Pascal with the correct detection in place although, I think having both Delphi and Pascal would be better, even if the split isn't possible to get correct in small repos. Delphi is easier to identify than Pascal and will not compile (without the Delphi compatibility flag) under something like Freepascal. |
|
And all delphi projects show as pascal now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain repositories (like https://github.com/graemeg/freepascal) are being shown as being written in Delphi instead of Pascal.
While Delphi is technically a different language to Pascal, I think it's still appropriate to call Delphi code Pascal, even if it may not be appropriate to call non-Delphi Pascal code (like a self-hosting Pascal compiler) Delphi. (does that make sense?)
cc @tnm