dramatically enhance colors for javascript and css #979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mr. Nyman and associates,
This pull request proposes subtle but important changes to the colors for JavaScript and CSS, updating them from their current colors, shown here:
And changing them to these:
The existing colors play on the traditional and played out red and blue motifs, whereas the updated colors, purple and yellow, are not only a more 21st century color color tuple choice but also each come from existing globally proven use cases.
#f7df1e
, the yellow used to represent JavaScript in this pull request, is also known as "JavaScript yellow" as it is the official yellow used in the JS logo: https://github.com/jsconf/logo.js/blob/master/js.svg#L19#563d7c
, aka "bootstrap purple", is an obvious choice for a CSS color refresh as this hex code represents the iconic brand of the most popular stylesheet in the universe.In preparation for this pull request I first analyzed the current color distribution across all languages (source available here):
As you can see, there are already a multitude of reds, yellows and purples, which assures me that these changes won't stand out relative to other colors used on GitHub today.
In closing I would like to leave you with this photo