Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dramatically enhance colors for javascript and css #979

Merged
merged 2 commits into from Apr 21, 2014

Conversation

Projects
None yet
8 participants
@maxogden
Copy link
Contributor

commented Mar 7, 2014

Mr. Nyman and associates,

This pull request proposes subtle but important changes to the colors for JavaScript and CSS, updating them from their current colors, shown here:

screen shot 2014-03-06 at 11 20 23 pm

And changing them to these:

screen shot 2014-03-06 at 11 19 41 pm

The existing colors play on the traditional and played out red and blue motifs, whereas the updated colors, purple and yellow, are not only a more 21st century color color tuple choice but also each come from existing globally proven use cases.

#f7df1e, the yellow used to represent JavaScript in this pull request, is also known as "JavaScript yellow" as it is the official yellow used in the JS logo: https://github.com/jsconf/logo.js/blob/master/js.svg#L19

#563d7c, aka "bootstrap purple", is an obvious choice for a CSS color refresh as this hex code represents the iconic brand of the most popular stylesheet in the universe.

In preparation for this pull request I first analyzed the current color distribution across all languages (source available here):

screen shot 2014-03-06 at 11 12 04 pm

As you can see, there are already a multitude of reds, yellows and purples, which assures me that these changes won't stand out relative to other colors used on GitHub today.

In closing I would like to leave you with this photo

1efa19a864fe11e392800a3677605d12_8

@mdo

This comment has been minimized.

Copy link
Member

commented Mar 7, 2014

Just going to go ahead and throw my undying support behind the CSS color change. <3

@arfon

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2014

👍

@muan

This comment has been minimized.

Copy link
Member

commented Mar 11, 2014

paisley
🐶

@bkeepers bkeepers added Triage and removed Triage labels Apr 21, 2014

@arfon arfon merged commit 54c1d7c into github:master Apr 21, 2014

1 check passed

default The Travis CI build passed
Details

arfon added a commit that referenced this pull request Apr 21, 2014

@mdo

This comment has been minimized.

Copy link
Member

commented Apr 22, 2014

@arfon Was it intentional to only merge one commit and not the other? Only curious because our pull request header here shows that you merged two commits :).

Edit: Derp, I might be mistaken here given the merged commit reference above. <3

@arfon

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2014

@mdo - I don't think I did anything wrong here but lemme know if something still isn't right 😄

@nickdesaulniers

This comment has been minimized.

Copy link

commented on 3a19ba4 Apr 24, 2014

what a dramatic enhancement!

This comment has been minimized.

Copy link
Contributor

replied Apr 24, 2014

Wow that hurts my eyes.

This comment has been minimized.

Copy link

replied Apr 25, 2014

@nickdesaulniers that was an unwarranted comment but it made me literally LOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.