Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub is using display:block for .markdown body table elements #460

Closed
justinjdickow opened this issue Feb 23, 2015 · 3 comments
Closed

Comments

@justinjdickow
Copy link

See this README for an example of tables not being rendered properly.

The style should be display:table.

@justinjdickow
Copy link
Author

Leaving source here because I plan on changing the source of that README:

protocol_spec

Byte 1 Byte 2 Byte 3 Byte 4
Version E Frame Type Service Type Control Frame Info Session ID
Byte 5 Byte 6 Byte 7 Byte 8
Date Size
Byte 9 Byte 10 Byte 11 Byte 12
Message ID

@bkeepers
Copy link
Contributor

bkeepers commented Mar 4, 2015

Hi @justinjdickow, thanks for reporting the issue. I have passed it on to our design team that manages our styles on GitHub.com.

Since this can't be fixed by a change to this library, I am going to close this issue.

@bkeepers bkeepers closed this as completed Mar 4, 2015
@bkeepers
Copy link
Contributor

bkeepers commented Mar 4, 2015

After discussing this with our design team, the reason we use display:block is so we can properly overflow the table if it is wider than the content. With display block, we can make the table itself scroll without affecting the width of the text surrounding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants