Add Puppet 6 support #226
Add Puppet 6 support #226
Conversation
A handful of the SSL tests would not pass successfully without specifying the SSL version range in the test server.
|
Hoping this gets merged.. Fantastic work @seanmil - I was really hoping to see this tool work for recent puppet installations again :) |
Add support for Puppet >= 6.5.0. The Puppet command Octocatalog-diff used was removed in 6.0.0 and an equivalent command was added back in 6.5.0. With this change, Octocatalog-diff detects the Puppet version and adjusts the Puppet command line as needed based on the version.
seanmil
force-pushed
the
add_puppet6_support
branch
from
f7a8634
to
40cc736
Compare
seanmil
force-pushed
the
add_puppet6_support
branch
from
80402e9
to
40cc736
Compare
|
@ashish1099 I re-ran the CI job. It passed, but I'm not sure why the results above still show "Waiting for status to be reported". Please see https://github.com/seanmil/octocatalog-diff/actions/runs/415637932 for the results. If we could get this merged, that would be great. Thank you. |
|
@seanmil hmm, I don't think I have any rights on this repo to merge this MR :) |
Oh, shucks, I thought you were with GitHub. Perhaps that was just my hope that someone there was paying attention to this project. |
But thanks for the PR, I have been using this branch for my testing setup 👍 |
|
next step would be a release of tag ? so I can just download the required tag. currently I have to mess around in my docker image to get things running, but no rush 👍 |
|
Yes - I'm planning on doing a release sometime this week (or maybe as a Christmas present, who knows 🎄 🎅) with this and a few other PRs rolled into it. 😄 |
Overview
This pull request introduces Puppet 6 support for computed catalogs and fixes issue #186 .
This change is based on the information contained in that issue and contains the conditional handling to make this change non-disruptive with existing Octocatalog-diff uses on older versions. It also contains updates to the testing suite to include tests covering the changes as well as updates to the CI pipeline to introduce Puppet 6 into the testing matrix.
Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:specor ignoring untestable sections of code with# :nocovcomments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests..gemfile into the vendor/cache directory.