Properly set filter rules for geo answers #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ross, verified and confirmed working ok |
ross
reviewed
Feb 15, 2018
octodns/provider/ns1.py
Outdated
| if has_country: | ||
| if len(params['answers']) > 1: |
There was a problem hiding this comment.
Looks like this change probably needs a corresponding tweak in the tests as this if always evaluates to true.
There was a problem hiding this comment.
Actually, that if check is unnecessary (since as you pointed out it's always true)
There was a problem hiding this comment.
Would removing it still apply a "shuffle" filter to records with a single answer? Not sure that'd be a problem, but I assume that was the original intent behind the if > 1
|
From my understanding, the shuffle filter needs to be present if there is
any geotarget involved.
…On Feb 15, 2018 10:52 AM, "Ross McFarland" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In octodns/provider/ns1.py
<#195 (comment)>:
> if has_country:
+ if len(params['answers']) > 1:
Would removing it still apply a "shuffle" filter to records with a single
answer? Not sure that'd be a problem, but I assume that was the original
intent behind the if > 1
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#195 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAvgKa5tMYBpLJAsGEo4qIu80kWkaqyNks5tVFKpgaJpZM4SD5tV>
.
|
|
The original intent was to handle shuffle when there was multiple answers
(regardless of geotarget). That seems to have been a misunderstanding of
our internal api
…On Feb 15, 2018 11:04 AM, "Stephen Coursen" ***@***.***> wrote:
From my understanding, the shuffle filter needs to be present if there is
any geotarget involved.
On Feb 15, 2018 10:52 AM, "Ross McFarland" ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In octodns/provider/ns1.py
> <#195 (comment)>:
>
> > if has_country:
> + if len(params['answers']) > 1:
>
> Would removing it still apply a "shuffle" filter to records with a single
> answer? Not sure that'd be a problem, but I assume that was the original
> intent behind the if > 1
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#195 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAvgKa5tMYBpLJAsGEo4qIu80kWkaqyNks5tVFKpgaJpZM4SD5tV>
> .
>
|
OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set filter rules when geo target information is configured. If the answer has no geo target, don't set the rules.