Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: replace jekyll-paginate with octopress-paginate #257

Open
Pym opened this issue Mar 19, 2016 · 17 comments
Open

Proposal: replace jekyll-paginate with octopress-paginate #257

Pym opened this issue Mar 19, 2016 · 17 comments
Assignees

Comments

@Pym
Copy link

Pym commented Mar 19, 2016

Hello there!

jekyll-paginate by @parkr is no longer under active development:

Feel free to build it, test it, and share widely. I worked on an idea in #22 but I just can't get excited about pagination. My vote is to kill off this version and move in a new vision that is as easy as possible to use, but still flexible.
@parkr

And that's exactly what @imathis developed: octopress-paginate

It's backward compatible plugin with jekyll-paginate but offers more possibilities, like the ability to paginate collections :)

@envygeeks
Copy link

@Pym it also tests on an outdated version of Jekyll and Ruby, neither of which Jekyll currently supports.

@shlok007
Copy link

shlok007 commented Jul 4, 2016

Is it still open? I would like to work on this..

@rogervila
Copy link

Any news on this?

@DirtyF
Copy link
Contributor

DirtyF commented Mar 16, 2017

AFAIC https://github.com/sverrirs/jekyll-paginate-v2 works fine and can be used with GitHub Pages as long as you build your site via Travis CI.

@r4fx
Copy link

r4fx commented Apr 22, 2017

Are there any obstacles to push it further?
Paginate collections is only the one thing that is missed for me currently on GitHub pages.

@benbalter
Copy link
Contributor

When you make a big change to a default like this across millions of sites, you have the potential to introduce friction (and thus frustration). Put another way "this is newer" is not a good enough reason to make a potentially breaking change. What's the advantage of Octopress paginate? What's wrong with the existing pagination solution? Are there existing bugs going unfixed? Is the octopress implementation 100% backwards compatible?

@BinaryMoon
Copy link

Jekyll paginate only paginates posts whereas Octopress paginates collections. That's the biggest benefit I think.

@r4fx
Copy link

r4fx commented Apr 29, 2017

I understand that replace plugins may brings frictions, so plaese don't replace but add to white list as new alternative, this will be safe for all.

@benbalter
Copy link
Contributor

add to white list as new alternative, this will be safe for all.

Adding more choices aren't always the right option. In the short term, you're adding cognitive burden as users need to evaluate which pagination library's best, weigh the relative tradeoffs, etc. In the long term, plugins have a non-zero maintenance cost in terms of security, documentation, support, and backwards compatibility.

AFAIC https://github.com/sverrirs/jekyll-paginate-v2 works fine and can be used with GitHub Pages as long as you build your site via Travis CI.

The readme notes that it's lacking some critical tests. If that plugin were to become a mature, drop-in replacement for jekyll-paginate, I'd prefer to go that route considering it's intended to be a continuation of the original functionality, not an alternative replacement.

@niyasc
Copy link

niyasc commented Nov 28, 2017

Hi, What is the status of this issue? Can we use jekyll-paginate-v2 for github pages? I was able to use it in local. But it did n't work when committed. I was not able to configure jekyll-paginate, which used to work earlier.

@DirtyF
Copy link
Contributor

DirtyF commented Nov 28, 2017

/cc @sverrirs

@sverrirs
Copy link

Hi all, and thanks for the mention, I'm the author of the jekyll-paginate-v2 plugin :)

The readme notes that it's lacking some critical tests. If that plugin were to become a mature, drop-in replacement for jekyll-paginate, I'd prefer to go that route considering it's intended to be a continuation of the original functionality, not an alternative replacement.

You´re absolutely correct @benbalter and honestly this sounds like the perfect motivation for me and some energetic co-programmers to beef up the coverage for this plugin.

As to the current state, the jekyll-paginate-v2 plugin is in a relatively feature stable state. There are 6 open issues, only one which is a bug (actually a regression related to the lazy member initialization discussed in another ticket in the jekyll project).

However, the major weakness of the jekyll-paginate-v2 project currently is that it only really has me as a contributor. I would be more than happy to add more people to the team and delegate maintenance and feature additions to ensure that it doesn't stagnate.

@parkr
Copy link
Contributor

parkr commented Nov 28, 2017

I would gladly support a move to replace jekyll-paginate with jekyll-paginate-v2. One way of reducing the bus factor is to migrate the project to the jekyll org, if you're up for that. Happy to have a discussion with you in an issue on jekyll-paginate-v2 about moving forward and shipping this plugin as a replacement to today's jekyll-paginate.

@sverrirs
Copy link

the bus factor

lol, deliciously dark ;)

@rogervila
Copy link

I would gladly support a move to replace jekyll-paginate with jekyll-paginate-v2. One way of reducing the bus factor is to migrate the project to the jekyll org, if you're up for that. Happy to have a discussion with you in an issue on jekyll-paginate-v2 about moving forward and shipping this plugin as a replacement to today's jekyll-paginate.

+1

@DirtyF
Copy link
Contributor

DirtyF commented Apr 5, 2019

Can we close this as a won't fix, it does not look like GitHub Pages is going to accept more plugins. Just use another hosting solution like Netlify that accept any Jekyll plugins.

@andrew-paterson
Copy link

Has this issue ever been revisited? It seems all the more relevant now, as jekyll-paginate is no longer under active development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests