Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captain ignores webhooks while building #266

Closed
olehermanse opened this issue Aug 31, 2018 · 2 comments
Closed

Captain ignores webhooks while building #266

olehermanse opened this issue Aug 31, 2018 · 2 comments

Comments

@olehermanse
Copy link

olehermanse commented Aug 31, 2018

Captain ignores webhooks while building. This means that if you push to multiple projects with GitHub webhooks, or have set up one github repo to send multiple webhooks to different captain apps, it won't work, some apps will never be built.

When 2 webhooks are received (roughly) at the same time, the second one is ignored with a 200 response, and this body:

{"status":1000,"description":"An active build (app name) is in progress... please wait..."}

If applicable, content of captain-definition file:
https://github.com/olehermanse/dagensquiz/blob/master/captain-definition
(It doesn't matter, though)

Steps to reproduce the problem:

  • Set up a GitHub repo for a captain app
  • Create 2 captain apps with different domains
  • Set up webhooks on pushes to master for both
  • 1 App will update, the other won't.

Captain should queue builds for different captain apps, and also not return 200 when the webhook was not successful.

@chromonav
Copy link

This problem is particularly a headache for mono-repos. Because of this captain does not initiate build for second app.

@githubsaturn
Copy link
Collaborator

Done. This feature will be available in the next release. For now, it's available on edge image:
https://caprover.com/docs/troubleshooting.html#how-to-use-the-edge-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants