Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Update this workshop to use Action.yml instead of a Dockerfile #9

Closed
bdougie opened this issue Nov 7, 2019 · 4 comments
Closed

Update this workshop to use Action.yml instead of a Dockerfile #9

bdougie opened this issue Nov 7, 2019 · 4 comments

Comments

@bdougie
Copy link

bdougie commented Nov 7, 2019

V2 leverages the action.yml and it is recommended in the help-docs guide.

https://help.github.com/en/actions/automating-your-workflow-with-github-actions/creating-a-javascript-action

@bdougie
Copy link
Author

bdougie commented Nov 7, 2019

Actually, not sure this would add any value since the hello world is bash. Maybe disregard.

Leaving for the sake of the discussion.

// proposed
name: My Hello World Action
author: me
description: 'Action that does some cool stuff!'
runs:
  using: 'docker'
  image: 'Dockerfile'

@mattdavis0351
Copy link
Contributor

Actions v2 can leverage both Docker based Actions as well as JavaScript based Actions. You reference the JavaScript Actions how-to-guide.

Take a quick read on the Docker Actions

Truth be told, both types of Actions request that we use action.yml to supply metadata.

If you're feeling adventurous consider checking out how you can contribute this fix directly by reading our contributing guide. In the meantime, I challenge you to a 🏎 🏎 🏎 to see who can fix it first 😄

@hectorsector
Copy link
Member

Thanks for the heads up, @bdougie

@mattdavis0351 -- this is what you and I were discussing recently, right? You mentioned action.yml is now recommended for Docker based actions, too.

@hectorsector
Copy link
Member

I think @mattdavis0351 did this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants