Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Clarify how to merge a pull request #68

Open
Calorion opened this issue Feb 26, 2021 · 0 comments
Open

Clarify how to merge a pull request #68

Calorion opened this issue Feb 26, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers markdown update Request for change to markdown
Projects
Learning Lab Course maintenance

Comments

@Calorion
Copy link

Calorion commented Feb 26, 2021 •
edited

Feature Request

Describe the problem/friction you are trying to solve
In Step 8: Merge your pull request, under Activity: Merge the pull request, 1. reads:

Click Merge pull request

It is, however, not immediately obvious to the beginner just where the “Merge pull request” button is. Is it at the top of the page? Is it on the Files changed tab we just used?

Describe your ideal solution
Change 1. to

Click Merge pull request below

i.e. add “below” to the end of the line.
@Calorion Calorion added the enhancement New feature or request label Feb 26, 2021
@brianamarie brianamarie added good first issue Good for newcomers markdown update Request for change to markdown labels Mar 2, 2021
@brianamarie brianamarie added this to Triage in Learning Lab Course maintenance via automation Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers markdown update Request for change to markdown
Projects
No open projects
Learning Lab Course maintenance
  
Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Calorion @brianamarie