Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight wording change? #122

Closed
amyschoen opened this issue Jul 31, 2018 · 2 comments
Closed

Slight wording change? #122

amyschoen opened this issue Jul 31, 2018 · 2 comments

Comments

@amyschoen
Copy link
Collaborator

I wanted to get some opinions on this before going ahead and doing a PR. I got some help proofreading my version of the guide for my upcoming class, and I got a suggestion on 02_getting_started.

In the "Snapshots, not Deltas section", snapshots of repos are defined as being commits. The reader thought it would provide more clarity to reword

When you create a new branch in Git, you are actually just creating a pointer that corresponds to the most recent snapshot in a line of work. Git keeps the snapshots for each branch separate until you explicitly tell it to merge those snapshots into the main line of work.

to

When you create a new branch in Git, you are actually just creating a pointer that corresponds to the most recent commit in a line of work. Git keeps the commits for each branch separate until you explicitly tell it to merge those commits into the main line of work.

in the "Branches are Lightweight and Cheap" section. Let me know what you think. I'll make the edits and submit a PR if folks think this is a good modification. Otherwise, feel free to close out this issue.

@brianamarie
Copy link
Contributor

Hi @amyschoen! I think this looks great. I would love to see this in a PR if you have the bandwidth. 😄 cc @githubtraining/trainers

@amyschoen
Copy link
Collaborator Author

Cool. I'll get the PR in and make the same changes to my version of the guide as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants