Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS information #58

Closed
brianamarie opened this issue Nov 17, 2017 · 4 comments
Closed

Add CODEOWNERS information #58

brianamarie opened this issue Nov 17, 2017 · 4 comments
Assignees

Comments

@brianamarie
Copy link
Contributor

The 2.11 release of GitHub Enterprise brought CODEOWNERS to the center stage. This is something we get a lot of questions about in class, so we want to cover it.

Existing documentation:

@githubtraining/trainers Do you think this would be best to include as a:

  • 👍 New activity
  • ❤️ Mentioned feature in Getting Started where we call out other important files
  • 🎉 Mentioned optional feature/activity combo in an appendix

@githubtraining/trainers Please emoji vote soon, and let me know if you have any questions. 🎈

@brianamarie brianamarie self-assigned this Nov 17, 2017
@hollenberry
Copy link
Contributor

👋 No strong feelings on how we should approach, but want to drop this stale PR in for reference:

#51

@brianamarie
Copy link
Contributor Author

👋 No strong feelings on how we should approach, but want to drop this stale PR in for reference:

#51

@hollenberry Thanks! I think the activity in this PR could be a good option if we choose 👍 new activity or 🎉 optional activity in the appendix.

@hollenberry & @githubtraining/trainers Friendly bump, please do emoji vote on the original post with your thoughts.

@crichID
Copy link
Contributor

crichID commented Nov 22, 2017

@brianamarie thank you for the bump. Students in my last few classes have been very interested in these features so I think it is worth a short activity but let's give the team another day to emoji vote and then we can make a decision. I did edit #51 a little to see if we could add the activity to github-games and whittle it down to 5 minutes or less.

@brianamarie
Copy link
Contributor Author

@githubtraining/trainers Based on the existing PR and current level of feedback, I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants