Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Linux app doesn't check if FirstRun dir exists #679

Closed
1 task done
killermoehre opened this issue Nov 11, 2023 · 3 comments
Closed
1 task done

On Linux app doesn't check if FirstRun dir exists #679

killermoehre opened this issue Nov 11, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@killermoehre
Copy link

🔍 Is there already an issue for your problem?

  • I have checked older issues, open and closed

📝 Description

On Linux, I had to create $HOME/.config/gitify/FirstRun/ by hand to make the app happy.

🪜 Steps To Reproduce

  1. make sure $HOME/.config/gitify/FirstRun doesn't exists.
  2. start gitify
  3. Enjoy an error message

ℹ System Info

OS: Arch Linux
Project Version: 4.4.0.r3.0fc4e8f (`main` branch checkout)

📸 Screenshots

No response

@killermoehre killermoehre added the bug Something isn't working label Nov 11, 2023
@hrqmonteiro
Copy link

Will someone look into this? The app is unusable on Linux (!!?)

@bmulholland
Copy link
Collaborator

@hrqmonteiro PRs are welcomed, especially because I don't think any maintainers run Linux.

@setchy
Copy link
Member

setchy commented Feb 16, 2024

gitify/first-run.js

Lines 37 to 51 in 1396b66

function isFirstRun() {
const configPath = getConfigPath();
try {
if (fs.existsSync(configPath)) {
return false;
}
fs.writeFileSync(configPath, '');
} catch (error) {
console.warn(`First run: Unable to write firstRun file`, error);
}
return true;
}
should be creating this directory if not present.

@setchy setchy added the help-wanted Extra attention is needed label Feb 16, 2024
@setchy setchy removed the help-wanted Extra attention is needed label Feb 17, 2024
@setchy setchy closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants