Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stashes created with command line don't show up in the "Stashes" section #1332

Closed
foreignmeloman opened this issue Jan 18, 2021 · 7 comments
Closed
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@foreignmeloman
Copy link

As the title says. Even after hitting the refresh button of the "Stashes" section, the new stash doesn't appear.

  • GitLens Version: 11.1.3
  • Git Version: 2.30.0
  • VSCode Version: 1.52.1 (system setup)
  • Commit: ea3859d4ba2f3e577a159bc91e3074c5d85c0523
  • Date: 2020-12-16T16:34:46.910Z
  • Electron: 9.3.5
  • Chrome: 83.0.4103.122
  • Node.js: 12.14.1
  • V8: 8.3.110.13-electron.0
  • OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. Create stash in the terminal window with git stash push command
  2. Refresh "Stashes" pane of GitLens
@foreignmeloman foreignmeloman added potential-bug triage Needs to be looked at labels Jan 18, 2021
@eamodio
Copy link
Member

eamodio commented Jan 18, 2021

I'm guessing this is caused by GitLens not being able to watch for repository changes. Typically this is because the repository root is outside the folder/workspace opened in VS Code (there is a VS Code issue tracking this).

If you enable output channel logging by setting "gitlens.outputLevel": "debug" in your settings. You can check in the GitLens channel in the Output pane to see if you see a log line that looks like Repository[<path-here>] doesn't support file watching;

If so, that explains the view not auto-refreshing. In tomorrow's Insiders edition, I have added watching in more cases to workaround the VS Code issue, and clear indicators if watching is unavailable.

Although, I am concerned that the refresh button didn't work (I can't reproduce that even when file watching isn't available).

Can you capture the logs for when you press the refresh button?

@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Jan 18, 2021
@eamodio eamodio self-assigned this Jan 18, 2021
@foreignmeloman
Copy link
Author

I'm guessing this is caused by GitLens not being able to watch for repository changes. Typically this is because the repository root is outside the folder/workspace opened in VS Code (there is a VS Code issue tracking this).

In my case the repository root is the same as opened project folder. The project has too many files to track and I get this message from VSCode on startup. I usually don't mind the autoupdate part and refresh Explorer and Source Control manually, but doing the same for GitLens panes doesn't work. Now I remember that new tags created in terminal also don't appear.
image

FYI I'm using Remote SSH connection, so the execution is not local.

Here is a screencap of the issue itself:
gitlens
And the recorded log: gitlens_log.txt

Hope this gives you some hints!

@eamodio eamodio added bug Something isn't working and removed needs-more-info Needs further information, steps, details, etc. potential-bug labels Jan 20, 2021
@eamodio eamodio added this to the Soon™ milestone Jan 20, 2021
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Jan 20, 2021
@eamodio
Copy link
Member

eamodio commented Jan 20, 2021

@foreignmeloman Thanks for the extra information -- it definitely helped. 😄

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@foreignmeloman
Copy link
Author

@eamodio Thanks for the quick response!

Unfortunately I see the same issue in the insiders version 2021.1.1904 :(
gitlens_insiders

And here is the log: gitlens_log2.txt

@eamodio eamodio reopened this Jan 20, 2021
@eamodio
Copy link
Member

eamodio commented Jan 21, 2021

@foreignmeloman Ah, the issue is that you have the previous insiders build, it needs to be v2021.1.2004 or later.

@eamodio eamodio closed this as completed Jan 21, 2021
@foreignmeloman
Copy link
Author

It works now, thanks!

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for community verification labels Jan 21, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Feb 3, 2021
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Feb 9, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

2 participants