Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve status bar blame flicker avoidance (and make it the default?) #1353

Closed
Tyriar opened this issue Jan 28, 2021 · 8 comments
Closed

Improve status bar blame flicker avoidance (and make it the default?) #1353

Tyriar opened this issue Jan 28, 2021 · 8 comments
Assignees
Labels
feature New feature or request needs-verification Request for community verification
Milestone

Comments

@Tyriar
Copy link

Tyriar commented Jan 28, 2021

When changing lines, the status bar entry hides and then shows again, sometimes with the same content.

recording (55)

Some ideas to avoid some visual noise:

  • Waiting up to 500ms or so before swapping out the stale text
  • Better caching of blame lines for the current file (if you're waiting on the git blame?)
  • Using the same status bar item instead of creating a new one?
@Tyriar Tyriar added potential-bug triage Needs to be looked at labels Jan 28, 2021
@eamodio
Copy link
Member

eamodio commented Jan 28, 2021

Can set "gitlens.statusBar.reduceFlicker": true,"

image

@eamodio eamodio closed this as completed Jan 28, 2021
@eamodio eamodio added already-exists Feature already exists and removed potential-bug triage Needs to be looked at labels Jan 28, 2021
@Tyriar
Copy link
Author

Tyriar commented Jan 28, 2021

I'm curious why this wouldn't be the default and only option?

@eamodio
Copy link
Member

eamodio commented Jan 28, 2021

For 2 main reasons -- because since it continues to show the previous value, its technically wrong, until it updates, and I prefer it off 😄

@Tyriar
Copy link
Author

Tyriar commented Jan 28, 2021

Hmm ok, well you're the boss 😄

Personally, this seems like a perfect opportunity to simplify the extension by removing a setting. An alternative approach could be to change the icon to a refresh icon briefly, the icon changing and status bar item remaining stable is better than the entry disappearing and appearing (esp. if there are more entries to the left).

@eamodio
Copy link
Member

eamodio commented Jan 29, 2021

Good idea with the icon, what do you think?

flicker-free

@eamodio eamodio reopened this Jan 29, 2021
@eamodio eamodio changed the title Avoid status bar blame flicker Improve status bar blame flicker avoidance (and make it the default?) Jan 29, 2021
@eamodio eamodio self-assigned this Jan 29, 2021
@eamodio eamodio added feature New feature or request and removed already-exists Feature already exists labels Jan 29, 2021
@eamodio eamodio added this to the Soon™ milestone Jan 29, 2021
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Jan 29, 2021
@eamodio
Copy link
Member

eamodio commented Jan 29, 2021

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@Tyriar
Copy link
Author

Tyriar commented Jan 29, 2021

Nice 👍, it might be better to avoid the spin animation to reduce some more noise?

@eamodio eamodio modified the milestones: Soon™, Shipped Feb 3, 2021
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Feb 9, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request needs-verification Request for community verification
Projects
None yet
Development

No branches or pull requests

2 participants