Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected repository detection on editor startup after recent updates #1372

Closed
Songworks opened this issue Feb 10, 2021 · 5 comments
Closed
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@Songworks
Copy link

  • GitLens Version: 11.2.1
  • Git Version: 2.30.0
  • VSCode Version: 1.53.1
  • OS Version: Ubuntu 20.04.2 LTS

Steps to reproduce:

I have a simple vscode .project file that looks like this:

{
	"folders": [
        {
            "path": "ee/source-code"
        },
        {
            "path": "."
        },
    ],
    "settings": {}
}

It contains several git repositories:

  • ./ee/source-code
  • ./ce/source-code
  • ./documentation

And I have the setting git.autoRepositoryDetection set to openEditors, so that only the repositories I actually work on, are detected for version control in VSCode.

However since a couple days (apparently both GitLens and VSCode had updates recently) all repositories are detected by GitLens on editor startup. I've tested that it happens with GitLens active only (though not if it's mayhaps a conflict with any other extension).

I can "fix" this by setting gitlens.advanced.repositorySearchDepth to 0 (rather than the default of 1) and get back to how I'd expect it to work. But I figured I'd mention this new, unexpected behaviour anyway.

Thanks for a great extension by the way.
Cheers!

@Songworks Songworks added potential-bug triage Needs to be looked at labels Feb 10, 2021
@DoctorPolski
Copy link

Not sure if this is somehow linked but similar to above I have some weirdness today after a number of various updates:

  • the rendered settings page for GitLens no longer shows graphics and the formatting is broken.
  • interactive rebase editor is broken
  • interactive rebase editor intercepts interactive rebases even when it is not enabled

Windows: 10.0.19042.789
VS Code: 1.53.1
Debian on WSL2: 4.19.104-microsoft-standard
Git: 2.20.1

There were recent updates to WSL2 Debian and the WSL plugin for VS Code.

@eamodio
Copy link
Member

eamodio commented Feb 10, 2021

@DoctorPolski definitely not related to this issue. Please try uninstalling and reinstalling GitLens to see if that helps. If not, please open a new issue. Thanks!

@eamodio eamodio self-assigned this Feb 28, 2021
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Feb 28, 2021
@eamodio eamodio added this to the Soon™ milestone Feb 28, 2021
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for community verification labels Feb 28, 2021
@eamodio
Copy link
Member

eamodio commented Feb 28, 2021

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Mar 5, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Mar 5, 2021
@Songworks
Copy link
Author

Songworks commented Mar 10, 2021

@eamodio Could not reproduce the problem on Gitlens Insider v2021.3.904 anymore.
Cheers!

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for community verification labels Mar 10, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

3 participants