Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLens premium walkthrough images missing #1838

Open
miguelsolorio opened this issue Feb 25, 2022 · 4 comments
Open

GitLens premium walkthrough images missing #1838

miguelsolorio opened this issue Feb 25, 2022 · 4 comments
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature blocked Blocked or caused by an upstream issue or feature bug Something isn't working

Comments

@miguelsolorio
Copy link
Contributor

image

馃憤 to using the walkthroughs, but noticed that the images in the walkthrough all appear missing/broken

  • GitLens Version: v2022.2.2417 (Insiders)
  • Git Version: 2.32.0 (Apple Git-132)

Version: 1.65.0-insider (Universal)
Commit: 8440b8f47231147823ba9696913d642e5f2d9d58
Date: 2022-02-25T05:18:40.990Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin arm64 21.3.0
@miguelsolorio miguelsolorio added potential-bug triage Needs to be looked at labels Feb 25, 2022
@miguelsolorio
Copy link
Contributor Author

Actually this might be a bug on VS Code as images are not showing up but svgs/gifs are...

@eamodio
Copy link
Member

eamodio commented Feb 28, 2022

@misolori Yeah, seems to only be happening in Insiders, stable VS Code seems fine. Do you know if there is an open issue?

@eamodio eamodio added blocked Blocked or caused by an upstream issue or feature blocked: vscode Caused by or dependent on a VS Code issue or feature bug Something isn't working and removed potential-bug triage Needs to be looked at labels Feb 28, 2022
@miguelsolorio
Copy link
Contributor Author

Yes, we'll be pulling this as a candidate since we are shipping this week, being tracked here microsoft/vscode#143985

@eamodio
Copy link
Member

eamodio commented Feb 28, 2022

@misolori awesome thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked: vscode Caused by or dependent on a VS Code issue or feature blocked Blocked or caused by an upstream issue or feature bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eamodio @miguelsolorio