Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line blame overlay is broken when commit message contains a ) #3018

Closed
jnjaeschke opened this issue Nov 15, 2023 · 4 comments
Closed

Line blame overlay is broken when commit message contains a ) #3018

jnjaeschke opened this issue Nov 15, 2023 · 4 comments
Assignees
Labels
bug Something isn't working support-triaged Support has reviewed, verified, or reproduced this verified ✔ Verified
Milestone

Comments

@jnjaeschke
Copy link

Description

Best described using the picture below. :)

When a commit message contains a ), the "open in commit graph" link in the gitlens line blame overlay is broken. This is a regular annoyance on my end because a colleague typically writes commit messages like Part 1) Description.

If the closed ) is opened in the commit message as well (e.g. Test ()), the behavior is as expected.

Steps to reproduce:
Create a commit with message Test ) to see the broken behavior.
Create a commit with message Test () to see that a closed parenthesis which doesn't have an opened parenthesis is the issue.

GitLens Version

14.5.0

VS Code Version

Version: 1.84.2 (Universal)
Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
Date: 2023-11-09T10:52:33.687Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.0.0

Git Version

git version 2.39.2

Logs, Screenshots, Screen Captures, etc

grafik

@jnjaeschke jnjaeschke added bug Something isn't working triage Needs to be looked at labels Nov 15, 2023
@Roberto-Vizcarra
Copy link

Hello!

Thank you for the report. I was able to reproduce the issue, so I will contact our dev team regarding this bug.

@Roberto-Vizcarra Roberto-Vizcarra added support-triaged Support has reviewed, verified, or reproduced this and removed triage Needs to be looked at labels Nov 15, 2023
@eamodio eamodio self-assigned this Nov 16, 2023
@eamodio eamodio added this to the 14.6 milestone Nov 16, 2023
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for community verification labels Nov 16, 2023
@eamodio
Copy link
Member

eamodio commented Nov 16, 2023

Can you please verify this fix in tomorrow's (v2023.11.16xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

@jnjaeschke
Copy link
Author

That fixed it, awesome! Thank you so much for the quick response :)

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for community verification labels Nov 16, 2023
@d13 d13 removed the pending-release Resolved but not yet released to the stable edition label Nov 21, 2023
@d13 d13 modified the milestones: 14.6, 14.5-patch Nov 21, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working support-triaged Support has reviewed, verified, or reproduced this verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

4 participants