Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opened revisions of file history are linted by the editor #452

Closed
infctr opened this issue Jul 20, 2018 · 3 comments
Closed

Opened revisions of file history are linted by the editor #452

infctr opened this issue Jul 20, 2018 · 3 comments

Comments

@infctr
Copy link

infctr commented Jul 20, 2018

So whenever I checkout the revision of a file (comparing commits) from GitLens File History sidebar (doesn't matter) the files in the diff view get linted by editor linters (ts, vscode-tslint, vscode-eslint) and all linting errors are shown in Problems panel and stay there after closing the diff view.

That seems like really an unexpected behavior because temp files are created in /var/folders/ and are not related to the project folder so linters should not lint these files at all. Morever, linted output stays in the Problems panel even when the files are closed and I couldn't find any other way to get rid of them other then Reload Window from command panel.

screenshot 2018-07-16 13 24 33

I was able to disable tslint linting with

"tslint.exclude": [
    "**/var/folders/**/*.*",
  ]

but not vscode ts linter.

So is there any way to disable revision preview files from being linted or is this a bug?

GitLens output log

  • GitLens Version: 8.5.2
  • VSCode Version:
    1.25.1
    1dfc5e557209371715f655691b1235b6b26a06be
    x64
  • OS Version:
    macOS High Sierra 10.13.5 (17F77)
@eamodio
Copy link
Member

eamodio commented Jul 20, 2018

Duplicate of #430. I am looking into avoiding these issues.

@infctr
Copy link
Author

infctr commented Aug 8, 2018

@eamodio Is there a way to manually remove these files from the Problems View at least? When files are closed they are not listed in Opened Editors and seems there's no other way to ignore the Problems output.

@github-actions
Copy link

github-actions bot commented Dec 5, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants