Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only process projects from within group namespace #17

Closed
gdubicki opened this issue Nov 18, 2017 · 2 comments
Closed

Only process projects from within group namespace #17

gdubicki opened this issue Nov 18, 2017 · 2 comments

Comments

@gdubicki
Copy link
Member

GitLab's API for getting projects within a project group (https://docs.gitlab.com/ce/api/groups.html#list-a-group-39-s-projects) returns also projects which are not really in the project group, but for which this group is used as a member.

For example let's assume that you have a project group foo with a project foo/bar in it. You also have a project different/other in a different group. And you make foo a member of the different/other project.

Then when you get projects from group foo you will get both foo/bar and different/other...

This is problematic for gitlabform as at least when we use it and configure it to apply some config for projects within a group foo then you mean to apply it to all projects within that group and only in that group namespace (so in the example above: only foo/bar)...

For now we used skip_projects as a workaround for this, but this is too problematic at this point to keep doing that.

@gdubicki
Copy link
Member Author

gdubicki commented Nov 18, 2017

Actually gitlabform currently assumes that all project names it gets from that API belong to given group namespace, so it results in 404 as foo/other (usually?) does not exist.

So I will fix this by only processing projects with foo namespace, so following the above example, onlyfoo/bar and it will be a safe change - it won't cause some projects which have been processed up to this point to be stopped being processed.

@gdubicki
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant