Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enforce support to schedule pipeline config #539

Closed
amimas opened this issue May 3, 2023 · 1 comment · Fixed by #561
Closed

Add enforce support to schedule pipeline config #539

amimas opened this issue May 3, 2023 · 1 comment · Fixed by #561

Comments

@amimas
Copy link
Collaborator

amimas commented May 3, 2023

Currently the scheduled pipeline configuration syntax is like this:

   group-name/project-name:
    schedules:
      Title of the schedule:
        ref: <branch-name>
        cron: <cron-expression>
        cron_timezone: <time-zone>
        variables:
          PIPELINE_VARIABLE1:
            value: <variable-value>

Consider the following 2 cases:

  • Rename the "Title of the schedule" to something else
  • Delete the entire schedule

In the first case, a new schedule will be created; existing schedule will remain in the project. For the 2nd case, nothing happens. The schedule from previous run of gitlabform will remain in the project.

In most cases the above is probably not expected. It'd be good to have enforce: true support for the schedules config so that any "unconfigured schedules" are deleted.

@gdubicki
Copy link
Member

gdubicki commented Jul 15, 2023

Released in v3.7.0 a moment ago. Thanks again for your contribution, @amimas! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants