Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usernames in projects and groups should be case-insensitive #555

Closed
J4Numbers opened this issue Jun 22, 2023 · 3 comments
Closed

Usernames in projects and groups should be case-insensitive #555

J4Numbers opened this issue Jun 22, 2023 · 3 comments

Comments

@J4Numbers
Copy link
Contributor

Background

Currently, a username in GitLab will resolve down to an ID at some level. That username exists as a namespace in front of the ID number and is case-insensitive when querying the GitLab list users API about it.

Existing behaviour

(As seen on 3.6.0)

Given that Joe.Bloggs already exists as a member of a group,

When running a configuration which includes a username of joe.bloggs against that group,

Then the GitLabForm attempts to add joe.bloggs to that group,

And the GitLabForm fails, stating that the ID number of Joe.Bloggs already exists against that group.

Proposed behaviour

Given that Joe.Bloggs already exists as a member of a group,

When running a configuration which includes a username of joe.bloggs against that group,

Then the GitLabForm does not attempt to add the existing member to that group.

@gdubicki
Copy link
Member

Hi, @J4Numbers, thanks for reporting the issue.

It's a known one though, discovered in #466 and some time ago I started working on a fix but I only found the time to implement tests that show that for now the names are treated as case-sensitive: #475

Sadly I still have little time so if you or someone else needs this badly, you can feel free to take over my PR (or start from the scratch, if you prefer) and implement it. Some day I might complete it myself, but I cannot tell you when, sorry.

@J4Numbers
Copy link
Contributor Author

I'd be happy to give it a shot! The tests will be a useful starting point.

@amimas
Copy link
Collaborator

amimas commented Sep 16, 2023

This is now available in v3.8.0: https://github.com/gitlabform/gitlabform/releases/tag/v3.8.0

@amimas amimas closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants