Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'security-fj-crlf-injection' into 'master'
[master] Fix CRLF issue in UrlValidator See merge request gitlab/gitlabhq!2627
- Loading branch information
Cindy Pallares
committed
Nov 29, 2018
1 parent
fe5f759
commit c0e5d9a
Showing
5 changed files
with
128 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Original file line | Diff line number | Diff line change |
---|---|---|---|
@@ -0,0 +1,5 @@ | |||
--- | |||
title: Fix CRLF vulnerability in Project hooks | |||
merge_request: | |||
author: | |||
type: security |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Original file line | Diff line number | Diff line change |
---|---|---|---|
@@ -0,0 +1,17 @@ | |||
shared_context 'invalid urls' do | |||
let(:urls_with_CRLF) do | |||
["http://127.0.0.1:333/pa\rth", | |||
"http://127.0.0.1:333/pa\nth", | |||
"http://127.0a.0.1:333/pa\r\nth", | |||
"http://127.0.0.1:333/path?param=foo\r\nbar", | |||
"http://127.0.0.1:333/path?param=foo\rbar", | |||
"http://127.0.0.1:333/path?param=foo\nbar", | |||
"http://127.0.0.1:333/pa%0dth", | |||
"http://127.0.0.1:333/pa%0ath", | |||
"http://127.0a.0.1:333/pa%0d%0th", | |||
"http://127.0.0.1:333/pa%0D%0Ath", | |||
"http://127.0.0.1:333/path?param=foo%0Abar", | |||
"http://127.0.0.1:333/path?param=foo%0Dbar", | |||
"http://127.0.0.1:333/path?param=foo%0D%0Abar"] | |||
end | |||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters