Skip to content
This repository has been archived by the owner on Apr 19, 2018. It is now read-only.

GPG-signed commits throws NoMethodError #17

Closed
kevinoconnor7 opened this issue Mar 28, 2013 · 0 comments · Fixed by #18
Closed

GPG-signed commits throws NoMethodError #17

kevinoconnor7 opened this issue Mar 28, 2013 · 0 comments · Fixed by #18

Comments

@kevinoconnor7
Copy link

This is a recreation of issue mojombo#141.

Long story short, when signing commits with GPG grit has trouble parsing around the GPG signature in the commit and throws NoMethodError. On gitlab 5.0 this means that repos that have GPG signed commits cannot be viewed.

User alexdo wrote a patch to resolve the issue by stripping out the GPG signature from the commit.

Here's the relevant section of the traceback:

undefined method `match' for nil:NilClass
/home/git/gitlab/vendor/bundle/ruby/1.9.1/gems/grit-2.5.0/lib/grit/commit.rb:286:in `actor'
/home/git/gitlab/vendor/bundle/ruby/1.9.1/gems/grit-2.5.0/lib/grit/commit.rb:158:in `list_from_string'
/home/git/gitlab/vendor/bundle/ruby/1.9.1/gems/grit-2.5.0/lib/grit/commit.rb:125:in `find_all'
/home/git/gitlab/vendor/bundle/ruby/1.9.1/gems/grit-2.5.0/lib/grit/repo.rb:381:in `commits'
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant