Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action version 1.1.4 still uses --pretty flag with gitleaks 7.0.0+ #16

Closed
stone-z opened this issue Dec 9, 2020 · 2 comments
Closed

Comments

@stone-z
Copy link

stone-z commented Dec 9, 2020

Hi 馃憢
Looks like the gitleaks v7.0.0 removed the --pretty flag. Unfortunately the action version 1.1.4 uses the latest image version but still includes the --pretty flag, so it breaks:

running gitleaks v7.1.0 with the following command馃憞
gitleaks --pretty --repo-path=/github/workspace --verbose --redact --commit=e0ec22ec6c76b425ad7c49ebb559f93a6520d966
unknown flag `pretty'
Usage:
  gitleaks [OPTIONS]
...

Sample run: https://github.com/giantswarm/hyperkube/runs/1525377670?check_suite_focus=true

edit: As a side note, I'm not sure if this is intentional behavior but it surprised me that this didn't fail the build

@zricethezav
Copy link
Collaborator

Thanks for alerting me @stone-z, https://github.com/zricethezav/gitleaks-action/releases/tag/v1.2.0 should fix it

@stone-z
Copy link
Author

stone-z commented Dec 12, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants