Add Defined Networking API Tokens Detector #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
jasikpark
force-pushed
the
add-defined-networking
branch
from
c6f4c23
to
67c7666
Compare
|
Rebased w/o the fixture to avoid setting off the detector xD |
jasikpark
commented
Feb 9, 2023
|
Anything I can do to push this PR forwards? Sorry to ping, just wanted to know if this is the right place to contribute. |
|
@jasikpark would you mind rebasing? Global allowlists have been updated |
Adds detection support for Defined Networking tokens (https://docs.defined.net/guides/automating-host-creation/) I added a fixture in addition to the generator, I think I may be able to use the `generateUniqueToken` instead of the semi-generic option? Let me know if I should update accordingly. Remove testing fixture
jasikpark
force-pushed
the
add-defined-networking
branch
from
67c7666
to
e201e87
Compare
|
@zricethezav done! |
|
woot 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds detection support for Defined Networking tokens (https://docs.defined.net/guides/automating-host-creation/)
I added a fixture in addition to the generator, I think I may be able to use the
generateUniqueTokeninstead of the semi-generic option? Let me know if I should update accordingly.Checklist: