Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rule descriptions for Stripe and Facebook access tokens #1119

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Mar 17, 2023

Description:

This PR aims to make it clear that facebook stripe rules refer to access tokens. The same is done for all other rules, so I think it's valuable :)

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

馃洜 with 鉂わ笍 by Siemens

@fgreinacher
Copy link
Contributor Author

@zricethezav I'm not sure what to do about the failing check. I saw this problem in another PR, but sounds like it should not happen anymore. My fork is up-to-date, can you support? 馃檱

@fgreinacher fgreinacher marked this pull request as ready for review March 17, 2023 13:46
@zricethezav
Copy link
Collaborator

Hi @fgreinacher, thanks for your second contribution to the project!

@zricethezav I'm not sure what to do about the failing check. I saw this problem in another PR, but sounds like it should not happen anymore. My fork is up-to-date, can you support? 馃檱

The failure might be happening because zricethezav/gitleaks was moved to gitleaks/gitleaks. Gitleaks is an organization and running gitleaks-actions on an organization requires a license key (which I added to the repo once it moved). I'm wondering if you forked this from the old zricethezav/gitleaks url and that's why it's failing.

Regardless, these changes LGTM and will be going out in the next release. Thanks again!

@zricethezav zricethezav merged commit 8a31f4a into gitleaks:master Mar 17, 2023
@fgreinacher fgreinacher deleted the improve-rule-descriptions branch March 17, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants