Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closing file in writeJson and writeSarif #1187

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fix closing file in writeJson and writeSarif #1187

merged 1 commit into from
Jun 5, 2023

Conversation

alexandear
Copy link
Contributor

Description:

This PR adds w.Close to writeJson and writeSarif to be the same as writeCsv which closes a file.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes? - N/A
  • Have you lint your code locally prior to submission?

@zricethezav
Copy link
Collaborator

Good call, thanks @alexandear

1 similar comment
@zricethezav
Copy link
Collaborator

Good call, thanks @alexandear

@zricethezav zricethezav merged commit 190ac97 into gitleaks:master Jun 5, 2023
1 check passed
@alexandear alexandear deleted the fix-close-file branch June 6, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandear @zricethezav