Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3 is missing the --depth option #299

Closed
morhimi opened this issue Nov 27, 2019 · 5 comments
Closed

Version 3 is missing the --depth option #299

morhimi opened this issue Nov 27, 2019 · 5 comments
Labels
good first issue Good for newcomers

Comments

@morhimi
Copy link

morhimi commented Nov 27, 2019

Since version 3 got released, the --depth option is no longer available.
how can I achieve that functionality in V3?

@arbazkiraak
Copy link
Contributor

this depth feature was indeed helpful in previous versions where we can only perform scans over newer commits , any reasons why it has been removed @zricethezav ?

@zricethezav
Copy link
Collaborator

@arbazkiraak No reason, I simply dropped the ball on including all the features when doing the v3 rewrite. This should be added in the next minor version release.

@zricethezav zricethezav added the good first issue Good for newcomers label Jan 12, 2020
@arbazkiraak
Copy link
Contributor

  • Since gitleaks now support commit scan range feature I don't think depth feature is necessary.

@morhimi
Copy link
Author

morhimi commented Jan 13, 2020

@arbazkiraak the range addition is 3.1 is very cool but it is not a good replacement for the depth option. nothing beats --depth 100 in simplicity and ease of use

@zricethezav
Copy link
Collaborator

cc @morhimi #321 going into 3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants