getNotifications is returning 500 code errors

[easyCZ]

Dashboard

query: sum(increase(gitpod_server_api_calls_total{method="getNotifications"}[7d])) by (statusCode)

[easyCZ]

@jankeromnes Landing #13178 caused this issue to close. But I believe the fix introduced does not actually fix the API returning 500 errors - it handles them on the UI side but does not stop them from happening server side. Are you happy for me to re-open?

[jankeromnes]

Hi @easyCZ! 👋

it handles them on the UI side but does not stop them from happening server side

Actually, #13178 handles them server side 😇

And looking at the code, I'm pretty sure that this does fix the API returning 500 errors (unless super throws, but that seems unlikely).

But please do re-open this if you notice more 500 errors from this call post deployment. 👍

[easyCZ]

Thanks @jankeromnes, I must have confused the PRs. This does look like it indeed handles them. I'll do some validation on this from the metrics side post rollout and will re-open if we continue to see issues.