Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for idmapped mounts instead of shiftfs #10181

Open
utam0k opened this issue May 23, 2022 · 5 comments · May be fixed by #14026
Open

Support for idmapped mounts instead of shiftfs #10181

utam0k opened this issue May 23, 2022 · 5 comments · May be fixed by #14026
Labels
meta: never-stale This issue can never become stale self-hosted team: workspace Issue belongs to the Workspace team

Comments

@utam0k
Copy link
Contributor

utam0k commented May 23, 2022 •
edited by kylos101

Is your feature request related to a problem? Please describe

We may have a chance to use idmapped mounts instead of shifts. idmapped has the merit that it doesn't need to kernel module because this feature is included kernel since >= 5.12. I'm not sure the performance, but at least it's better than fuse.
https://github.com/lxc/lxd/pull/8778/files

And, it may help the self-hosted users because the users use it easily, and don't need to install fuse-overlayfs or kernel module.

Describe the behaviour you'd like

  1. Pass the integration test with idmapped mounts, with fuse, shiftfs, and id mapped mounts.
    • Update harvestor preview environments to use ID mapped mounts
    • workspace-preview changed to id-mapped and tested
    • Production (ops repo) changed to id-mapped and tested with an ephemeral cluster
  2. Share thoughts on how to automate testing with fuse and shiftfs in a new (separate issue), as the current tests will only use what is in the preview environment.
  3. Update the product compatibility matrix (internal)

Describe alternatives you've considered

Additional context

Internal conversation
@utam0k utam0k added team: workspace Issue belongs to the Workspace team team: delivery Issue belongs to the self-hosted team labels May 23, 2022
@corneliusludmann corneliusludmann added self-hosted and removed team: delivery Issue belongs to the self-hosted team labels May 23, 2022
@Furisto
Copy link
Member

Furisto commented May 24, 2022

Hi @utam0k, we need to wait for kernel 5.19 because only then overlayfs will support id mapped mounts.

@utam0k
Copy link
Contributor Author

utam0k commented May 24, 2022

@Furisto cc: @kylos101
Thanks for your information. Is this a patch you pointed out?
https://lkml.kernel.org/linux-unionfs/20220329103526.1207086-10-brauner@kernel.org/T/

@kylos101
Copy link
Contributor

Good timing, @Furisto , thanks for the heads up.

@kylos101
Copy link
Contributor

kylos101 commented Jun 8, 2022

@aledbf I updated this issue and asked @utam0k to share an estimate, so we can use the estimate as input to gauge if we can schedule.

@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 8, 2022
@utam0k utam0k removed the meta: stale This issue/PR is stale and will be closed soon label Sep 9, 2022
@kylos101 kylos101 added the meta: never-stale This issue can never become stale label Sep 9, 2022
@csweichel csweichel linked a pull request Oct 20, 2022 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta: never-stale This issue can never become stale self-hosted team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ws-daemon] Add support for idmapped mounts gitpod-io/gitpod
4 participants
@kylos101 @utam0k @Furisto @corneliusludmann