Cannot "open preferences" inside developed Theia application

[paul-marechal]

Describe the bug
When running a Theia application from within gitpod, it seems like I cannot open the preferences (the button click does nothing).

To Reproduce
https://gitpod.io/#https://github.com/theia-ide/theia/pull/2602
Start the browser example application, go to File > Open Preferences.
It should do nothing.

Expected behavior
We could expect the preferences to be opened.

[akosyakov]

It's Theia bug, the preference widget should use the editor manager to open an editor, instead of trying to reimplement an editor opening himself: https://github.com/theia-ide/theia/blob/842196b5b18ce340f6b1beaea9e9a7ddbe2fd96f/packages/preferences/src/browser/preferences-tree-widget.ts#L193-L196

[paul-marechal]

I do not see the same code on master: https://github.com/theia-ide/theia/blob/master/packages/preferences/src/browser/preferences-tree-widget.ts#L99-L113

I am kind of confused.

Although if this is a Theia problem, would it make sense to report it on the issue tracker?

Because if you feel confident that this is not a gitpod issue we can close this ticket, as it might be better to continue on the Theia repo.

[akosyakov]

Yes, I'm pretty sure, the internal contract was changed, the editor factory excepts an object, no a URI. But it is all implementation details, clients should just always use EditorManager.

[akosyakov]

Will be resolved with eclipse-theia/theia#2615

[akosyakov]

it was resolved already