Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Open in GitHub' doesn't work in diff view #322

Closed
jankeromnes opened this issue Feb 19, 2019 · 1 comment
Closed

'Open in GitHub' doesn't work in diff view #322

jankeromnes opened this issue Feb 19, 2019 · 1 comment
Labels
meta: stale This issue/PR is stale and will be closed soon type: bug Something isn't working

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Feb 19, 2019

Describe the bug
Using 'Open in GitHub' from the diff view takes you to a broken GitHub URL with the right lines but no file name.

To Reproduce

  1. Open a pull request in Gitpod, e.g. https://gitpod.io/#https://github.com/theia-ide/theia/pull/4166
  2. Select code from somewhere in the diff view
  3. Right-click on the selection, and pick 'Open in GitHub'

This takes you to a broken GitHub URL with the right lines but no file name, e.g.:

https://github.com/jankeromnes/theia/tree/12eeb92bf750da5a7bfe9d9cdb6c7e6b64dc0251#L181-L183

Expected behavior

The GitHub URL should also have the file name, e.g.:

https://github.com/jankeromnes/theia/blob/12eeb92bf750da5a7bfe9d9cdb6c7e6b64dc0251/packages/navigator/src/browser/navigator-contribution.ts#L181-L183

@stale
Copy link

stale bot commented Mar 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 18, 2021
@stale stale bot closed this as completed Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: stale This issue/PR is stale and will be closed soon type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants