Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing Commits #467

Closed
benrobot opened this issue Apr 10, 2019 · 2 comments
Closed

Signing Commits #467

benrobot opened this issue Apr 10, 2019 · 2 comments
Labels
meta: stale This issue/PR is stale and will be closed soon type: feature request New feature or request

Comments

@benrobot
Copy link

When I develop at my desktop I regularly use:

git commit -S -m "Fixed something..."

Where -S in the command causes the commit to get signed with my private key. When I push the changes to GitHub, GitHub verifies the signature against my public key that I uploaded to them previously. They even put a little button that says Verified next to each commit that I signed.

commit_signed_locally_by_user

I'd like for commits made from my GitPod to somehow be signed as well. I can think of two options at the moment:

  1. Invent a process where git commit -S outputs the string to be signed and waits for the user to copy that string locally, use GPG to sign it with her private key and then copy the signed output back into the GitPod command line that was waiting for it. This option may not be possible without coding some new commit signing handler.
  2. Maybe GitPod could sign the commit similar to how GitHub signs commits when editing a file using their Web interface.

Here's a little more information related to option 2:
According to this page Managing commit signature verification GitHub will automatically sign commits you make using the GitHub web interface.
commit_signed_by_github

@svenefftinge svenefftinge added the type: feature request New feature or request label Apr 11, 2019
@corneliusludmann
Copy link
Contributor

In my opinion, option 1 seems to be rather complicated and cumbersome. Option 2 is not possible unless (a) Gitpod has your private GPG key or (b) generates a private GPG key whose public key you need to add to GitHub. In both cases Gitpod have to manage the secure storage of the private key of the users.

See also the discussion of #666.

@stale
Copy link

stale bot commented Mar 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 18, 2021
@stale stale bot closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: stale This issue/PR is stale and will be closed soon type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants