Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-manager] Properly stop workspaces that time out during backup #4937

Closed
csweichel opened this issue Jul 25, 2021 · 1 comment · Fixed by #4943
Closed

[ws-manager] Properly stop workspaces that time out during backup #4937

csweichel opened this issue Jul 25, 2021 · 1 comment · Fixed by #4943
Labels
component: ws-manager groundwork: awaiting deployment operations: past incident This issue arose during a past incident or its post-mortem priority: highest (user impact) Directly user impacting type: bug Something isn't working
Projects
[DEPRECATED] Product Engineering Grou...

Comments

@csweichel
Copy link
Contributor

Bug description

Right now when a workspace times out during backup it remains "stuck in terminating" because we don't set the disposal status annotation, and hence don't remove the finalizer.

Steps to reproduce

Have the workspace time out in backup, e.g. due to a ws-daemon failure.

Expected behavior

The workspace should stop properly.

Example repository

No response

Anything else?

No response
@csweichel csweichel added type: bug Something isn't working component: ws-manager labels Jul 25, 2021
@csweichel csweichel added operations: past incident This issue arose during a past incident or its post-mortem priority: highest (user impact) Directly user impacting labels Jul 25, 2021
@csweichel
Copy link
Contributor Author

/schedule

@roboquat roboquat moved this from Inbox to Scheduled (limit: 25 WIP) in [DEPRECATED] Product Engineering Groundwork Jul 25, 2021
@csweichel csweichel mentioned this issue Jul 25, 2021
Merged
@roboquat roboquat moved this from Scheduled (limit: 25 WIP) to In Review in [DEPRECATED] Product Engineering Groundwork Jul 25, 2021
@roboquat roboquat moved this from In Review to Awaiting Deployment in [DEPRECATED] Product Engineering Groundwork Jul 26, 2021
@ArthurSens ArthurSens moved this from Awaiting Deployment to Done in [DEPRECATED] Product Engineering Groundwork Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ws-manager groundwork: awaiting deployment operations: past incident This issue arose during a past incident or its post-mortem priority: highest (user impact) Directly user impacting type: bug Something isn't working
Projects
No open projects
[DEPRECATED] Product Engineering Grou...
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ws-manager] Stop workspaces timing out during backup gitpod-io/gitpod
2 participants
@csweichel @roboquat