Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] If a prebuild's snapshot fails with "out of disk" it does not report "failed" (just empty "snapshot") #9710

Closed
geropl opened this issue May 3, 2022 · 1 comment · Fixed by #10053
Assignees
Labels
component: ws-manager self-hosted team: workspace Issue belongs to the Workspace team type: bug Something isn't working

Comments

@geropl
Copy link
Member

geropl commented May 3, 2022

Corollary to: #9676

version: 2022.04.1 (self-hosted installation)

Instead of resulting in an status update of "phase": 6, "conditions": { "failed": "some error" }, ws-manager-bridge receives:

"phase": 6,
"conditions": {
    "failed": "",
    "timeout": "",
    "pullingImages": 0,
    "snapshot": "",
    "finalBackupComplete": 1,
    "deployed": 0,
    "networkNotReady": 0,
    "headlessTaskFailed": "",
    "stoppedByRequest": 0
}
@geropl geropl changed the title [prebuilds] "out of disk"does not result in "failed" (just empty "snapshot") [ws-manager] If a prebuild's snapshot fails with "out of disk" it does not report "failed" (just empty "snapshot") May 3, 2022
@jldec jldec added the team: workspace Issue belongs to the Workspace team label May 8, 2022
@sagor999 sagor999 self-assigned this May 16, 2022
@sagor999
Copy link
Contributor

@geropl while trying to repro this case, I noticed an odd behaviour that I think is due to a fix for #9676 :
when prebuild has finished, and snapshot is being taken, prebuild will show up in dashboard in ERROR state. After snapshot was taken, it will get updated into READY state. But when I go into list of prebuilds, it still shows up there as in ERROR state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ws-manager self-hosted team: workspace Issue belongs to the Workspace team type: bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants