-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add logout functionality #40
Comments
Any steps for the new people to the repo to follow? Also, any thoughts about the design? I think a logout link in the profile page would be enough. |
Thank you @alejandronanez, I had it all in mind and just realized I didn't actually write it down 😞 . So the 2 caveats:
|
I started to play with logging out a bit and at the moment i have the following. By clicking yes you would navigate to the 'Login' screen. At this moment i'm trying to figure out how to clear the userData (log the user out). Let me know if i should push my branch and create a pr or its better to combine this with a possible editing feature. |
@RolfKoenders that looks amazing 😍 Yep so I had the idea in another ticket #8 for updating profile details to have a little cog wheel icon to navigate to the screen where the user can update their info. I was thinking of having Log Out there but I actually really what you did there. I think this is great for now and when the user profile details screen is created --> we can decide if we want to just move the listitem there or leave it where it is now. Couple of tiny tiny nitpicks I can see (and I know I could have waited for a PR to put this):
Aside from these tiny things, this is awesome matey. More than happy to have you submit a PR with a dummy |
As referenced above i created a pr and here are the other answers.
|
Can be closed (#131) 😄 |
So we can't logout of the app right now :). Currently users have to delete the app and redownload in order to sign in with another account.
We can just navigate the user to the initial welcome screen (might be worth clearing our persisted store too).
The text was updated successfully, but these errors were encountered: