fix: Fix button transparency on Android #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @machour Looking this pr (https://github.com/react-native-training/react-native-elements/pull/382 ) looks like they added a outline props that should do the same thing, Could you test it? Maybe fits in our user case 😄 Ps. This is not documented yet on react-native-elements site :( |
|
@jouderianjr already tested it (and transparent too), same white background on Android:
|
|
oh, got it 😄 |
jouderianjr
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this is now needed by
react-native-elementsbutton to correctly render a transparent button absolutely positioned.(we bumped from "^0.9.3" to "^0.17.0" in #407)